-
-
Notifications
You must be signed in to change notification settings - Fork 171
Added starting point to move over to cocoapods plugin #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1e2d911
to
a171b30
Compare
� Conflicts: � firebase-database/build.gradle.kts
ff163ed
to
fb030ad
Compare
LGTM - what is the recommended way to include the firebase-kotlin-sdk and firebase in your xcode project now then? |
Two ways, either generating the pod file or you could just add like we normally do. |
Umm... so all of iOS is now TODO? Is there a plan for that? It was very surprising to spend the time updating to the latest release here and find that everything was broken at runtime for iOS. |
What do you mean everything is todo? It's working. What isn't working for you? |
@Reedyuk Oh I guess it's only for creating Firebase product classes from a specific FirebaseApp instance (which I use extensively in my app). I refer to all of these: Still a very sneaky and surprising change that would've been nice to have more upfront communication about in release notes or even the PR description. So what was the issue there? Something very tricky? Happy to assist if if it's not :P |
I've not had chance to look at it, yes sorry was my fault. |
A lot of time was spent just getting it to work with cocoa pods plug-in and then the pain of compilation 😂 |
Are you suggesting that bridging Gradle, Kotlin, iOS, and Cocoapods is complicated? 😂 😂 😂 I'll take a dive into it next week maybe. |
Could this fix it or be related? I noticed a warning in my own project that recommended I add this after upgrading to kotlin 1.8.20
https://kotlinlang.org/docs/multiplatform-share-on-platforms.html#share-code-on-all-platforms |
Kotlin 1.8.20 has a few fixes that allows us to use cocoapods instead of carthage.
Converted all subprojects to use cocoapods plugin instead of carthage.
Added caching(works better when its in main branch)
@nbransby or @michaelprichardson - do you want to review this? its a fairly big change.