Skip to content

[11.9] Add support for access_level in Projects::createProjectAccessToken #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dododedodonl
Copy link
Contributor

Add the access_level parameter, as specified in the documentation.

@stale
Copy link

stale bot commented Mar 6, 2023

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 6, 2023
@GrahamCampbell GrahamCampbell changed the title Feature/add access level parameter [11.9] Add support for access_level in Projects::createProjectAccessToken Mar 6, 2023
@GrahamCampbell GrahamCampbell changed the base branch from 11.8 to 11.9 March 6, 2023 12:03
@GrahamCampbell GrahamCampbell merged commit f788d19 into GitLabPHP:11.9 Mar 6, 2023
@GrahamCampbell
Copy link
Member

Thanks for the PR. 👍

@GrahamCampbell
Copy link
Member

It looks like the tests are failing here. I've had to revert this.

GrahamCampbell added a commit that referenced this pull request Mar 6, 2023
@dododedodonl
Copy link
Contributor Author

dododedodonl commented Mar 6, 2023

@GrahamCampbell I'm not sure what the problem is, I do not use psalm myself and wrote the code quite some time ago. It looks like it has to do something with the type that is specified in the doctag. It looks correct to me though, as it uses an int in the testcase.

@GrahamCampbell
Copy link
Member

The failure was not psalm, but phpunit (at least, the psalm failure was not related to this PR).

@GrahamCampbell
Copy link
Member

dododedodonl pushed a commit to dododedodonl/Client that referenced this pull request Mar 7, 2023
dododedodonl added a commit to dododedodonl/Client that referenced this pull request Mar 7, 2023
Bumped year

Bumped versions

Support PHPUnit 10

Added PHP 8.2 support

[11.9] Deploy Tokens (GitLabPHP#701)

Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>

[11.9] Add source parameter to pipelines API (GitLabPHP#708)

Co-authored-by: Christoph Rosse <christoph.rosse@niceshops.com>

[11.9] Add support for `Projects::pipelineTestReport` & `Projects::pipelineTestReportSummary` (GitLabPHP#709)

* Add support for `Projects::pipelineTestReport`

* Add support for `Projects::pipelineTestReportSummary`

[11.9] Allow `update_at` order by in `Projects::pipelines` (GitLabPHP#710)

Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>

[11.9] Feature/groups issues (GitLabPHP#714)

Update CHANGELOG.md

[11.9] Add support for `allowed_to_create` in `Projects::addProtectedTag` (GitLabPHP#736)

[11.9] Add support for user starred projects (GitLabPHP#735)

Co-authored-by: Wim Reckman <wim.reckman@endeavour.nl>

[11.9] Add support for `Projects::projectAccessToken` (GitLabPHP#715)

Co-authored-by: Niek Brekelmans <niek@dcc.team>

[11.9] Add support for `Jobs::artifactByJobId` (GitLabPHP#734)

[11.9] Add ability to authenticate with a job token (GitLabPHP#722)

Update CHANGELOG.md

Revert "[11.9] Add support for `access_level` in `Projects::createProjectAccessToken` (GitLabPHP#731)"

This reverts commit f788d19.

Update psalm-baseline.xml

Release 11.9.0
@dododedodonl
Copy link
Contributor Author

I am not that used to github, and missed the second action job. While fixing this I mixed up another local version of the sdk, and it was easier to create a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants