-
Couldn't load subscription status.
- Fork 23
Java: Use the models packs in the query pack and promote experimental models. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…so added in the wrong qlpack).
d5ec5da to
6b1a690
Compare
|
Thanks @michaelnebel What were all those |
That was a way of "activating" (only include specific) experimental Models as Data models for a given query. Since the experimental models are converted to "ordinary" models (which means that they also apply to all queries), we no longer need to "activate" anything. |
In this PR we
DCA was used to check that this didn't cause any massive discrepancies: https://github.com/github/codeql-dca-main/issues/24959
The experiment shows no changes in alerts or performance.
For the curious reader, here are the tuple counts for the queries in the default query suite for the java DCA projects: https://github.com/github/codeql-dca-main/blob/data/michaelnebel/auto/community-pack/e876bc7/1732286194857/reports/summaries/csv/Query_result_tuple_counts.csv
The experiment was started using the DCA command (for this to be reproducible https://github.com/github/codeql-dca/pull/2324 needs to be merged):