Skip to content

Stick the offset when height changes #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2018
Merged

Stick the offset when height changes #81

merged 3 commits into from
Oct 14, 2018

Conversation

rnystrom
Copy link
Member

@rnystrom rnystrom commented Sep 22, 2018 •
edited
Loading

Noticed in GitHawk that as you newline, the offset doesn't move precisely w/ the height change.

Still debugging a little to get this right.

@rnystrom
Copy link
Member Author

Seems to be the right fix

@rnystrom rnystrom merged commit 41e1a67 into master Oct 14, 2018
@rnystrom rnystrom deleted the offset-stick branch October 14, 2018 03:07
rnystrom added a commit that referenced this pull request Oct 14, 2018
@rnystrom
Revert "Stick the offset when height changes (#81)"
e29a5ee 
This reverts commit 41e1a67.
rnystrom added a commit that referenced this pull request Oct 14, 2018
@rnystrom
Revert "Calculate scroll view frame correctly" (#83)
949dc75 
* Revert "Stick the offset when height changes (#81)"

This reverts commit 41e1a67.

* Revert "Calculate scroll view frame correctly (#72)"

This reverts commit 5d30ee4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rnystrom