Skip to content

Add overridable didLayout API #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Add overridable didLayout API #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions MessageViewController/MessageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ open class MessageViewController: UIViewController, MessageAutocompleteControlle
}
}

open func didLayout() { }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some header docs to give a hint as to what this can be used for might help :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR!


// MARK: Private API

// keyboard management
Expand Down Expand Up @@ -132,6 +134,8 @@ open class MessageViewController: UIViewController, MessageAutocompleteControlle
)

messageAutocompleteController.layout(in: view, bottomY: messageViewFrame.minY)

didLayout()
}

internal var fullCacheKey: String? {
Expand Down