-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage support #61
base: master
Are you sure you want to change the base?
Carthage support #61
Conversation
…geViewController into carthage-support
@wickwirew I’d prefer to leave the examples alone so that someone can just download and run the sample vs having to run install scripts. Would you mind restoring those? Sent with GitHawk |
@rnystrom Sorry should elaborated more but having the Example workspace is what’s causing the issue. When Carthage looks for the Sent with GitHawk |
I don’t know much about carthage. Why does it make this mistake? Sent with GitHawk |
Carthage will build all shared schemes in a repository. A But I suggest giving Carthage a try! Started using it a few months ago and have been very happy with how its working out. Just a thought, but we can get the desired behavior of not having to run |
Initially when trying to use Carthage there would be a build error. Carthage was trying to build the
MessageViewController
scheme in the example workspace.This PR removes the example workspace, so to run the example project now you will have to run
pod install
prior. Carthage has no way, yet, to ignore specific schemes. All of the example CocoaPod specific files were added to the gitignore as well. Also I lowered the target to iOS 10. I can put it lower if you would like.Also fixes a bug in the example project.
inset
was renamed totextViewInset
Let me know if you would like anything changed!