Remove autocomplete on single backspace #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves GitHawkApp/GitHawk#1514
I did a little reverse engineering of Slack to figure out how they were dealing with this. The text after a mention is still highlighted for autocorrect, so they do not toggle it on and off, they simply ignore the replacement.
This only automatically removes an autocorrect for a single backspace starting at the end.
This is a bit of a heuristic. It works well because a suggested autocorrect is rarely if ever 1 character long.
Existing problems that this does not fix:
autocompletefrom the middle(Slack handles this by changing the text but removing the autocomplete attributes)