Highlighting with NSAttributedString's #15
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // | ||
| // NSAttributedString+ReplaceRange.swift | ||
| // MessageViewController | ||
| // | ||
| // Created by Nathan Tannar on 1/31/18. | ||
| // Copyright © 2018 Ryan Nystrom. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| extension NSAttributedString { | ||
|
|
||
| func replacingCharacters(in range: NSRange, with attributedString: NSAttributedString) -> NSMutableAttributedString { | ||
| let ns = NSMutableAttributedString(attributedString: self) | ||
| ns.replaceCharacters(in: range, with: attributedString) | ||
| return ns | ||
| } | ||
|
|
||
| static func +(lhs: NSAttributedString, rhs: NSAttributedString) -> NSAttributedString { | ||
|
|
||
| let ns = NSMutableAttributedString(attributedString: lhs) | ||
| ns.append(rhs) | ||
| return NSAttributedString(attributedString: ns) | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| // | ||
| // NSAttributedString+HighlightingTests.swift | ||
| // MessageViewControllerTests | ||
| // | ||
| // Created by Nathan Tannar on 2/1/18. | ||
| // Copyright © 2018 Ryan Nystrom. All rights reserved. | ||
| // | ||
|
|
||
| import XCTest | ||
| import MessageViewController | ||
|
|
||
| class NSAttributedString_HighlightingTests: XCTestCase { | ||
|
|
||
| var controller: MessageAutocompleteController? | ||
| var textView: MessageTextView? | ||
|
|
||
| /// A key used for referencing which substrings were autocompletes | ||
| private let NSAttributedAutocompleteKey = NSAttributedStringKey.init("com.system.autocompletekey") | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. | ||
|
|
||
| textView = MessageTextView() | ||
| controller = MessageAutocompleteController(textView: textView!) | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| // Put teardown code here. This method is called after the invocation of each test method in the class. | ||
| controller = nil | ||
| textView = nil | ||
|
|
||
| super.tearDown() | ||
| } | ||
|
|
||
| func test_TailHighlight() { | ||
|
|
||
| guard let textView = textView else { return XCTAssert(false, "textView nil") } | ||
| guard let controller = controller else { return XCTAssert(false, "controller nil") } | ||
|
|
||
| let prefix = "@" | ||
| controller.register(prefix: prefix) | ||
|
|
||
| let nonAttributedText = "Some text " + prefix | ||
| textView.attributedText = NSAttributedString(string: nonAttributedText) | ||
| controller.didChangeSelection(textView: textView) | ||
| guard controller.selection != nil else { | ||
| return XCTAssert(false, "Selection nil") | ||
| } | ||
| let autocompleteText = "username" | ||
| controller.accept(autocomplete: autocompleteText) | ||
| let range = NSRange(location: nonAttributedText.count - 1, length: autocompleteText.count) | ||
| let attributes = textView.attributedText.attributes(at: range.lowerBound, longestEffectiveRange: nil, in: range) | ||
| guard let isAutocompleted = attributes[NSAttributedAutocompleteKey] as? Bool else { | ||
| return XCTAssert(false, attributes.debugDescription) | ||
| } | ||
| XCTAssert(isAutocompleted, attributes.debugDescription) | ||
| } | ||
|
|
||
| func test_HeadHighlight() { | ||
|
|
||
| guard let textView = textView else { return XCTAssert(false, "textView nil") } | ||
| guard let controller = controller else { return XCTAssert(false, "controller nil") } | ||
|
|
||
| let prefix = "@" | ||
| controller.register(prefix: prefix) | ||
|
|
||
| let nonAttributedText = prefix | ||
| textView.attributedText = NSAttributedString(string: nonAttributedText) | ||
| controller.didChangeSelection(textView: textView) | ||
| guard controller.selection != nil else { | ||
| return XCTAssert(false, "Selection nil") | ||
| } | ||
| let autocompleteText = "username" | ||
| controller.accept(autocomplete: autocompleteText) | ||
|
|
||
| let highlightRange = NSRange(location: nonAttributedText.count - 1, length: autocompleteText.count) | ||
| let attributes = textView.attributedText.attributes(at: highlightRange.lowerBound, longestEffectiveRange: nil, in: highlightRange) | ||
| guard let isAutocompleted = attributes[NSAttributedAutocompleteKey] as? Bool else { | ||
| return XCTAssert(false, attributes.debugDescription) | ||
| } | ||
| XCTAssert(isAutocompleted, attributes.debugDescription) | ||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder for me: I should start adding docs 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😝 Every devs favorite task