Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Dismiss spinner only after code view is rendered #2611

Merged

Conversation

viktorasl
Copy link
Contributor

Closes #2492

@Huddie Huddie added the 💤 awaiting review Pull Request is awaiting code reviews label Feb 13, 2019
Copy link
Collaborator

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@BasThomas BasThomas merged commit 4986fd7 into GitHawkApp:master Mar 9, 2019
@BasThomas BasThomas removed the 💤 awaiting review Pull Request is awaiting code reviews label Mar 9, 2019
@Huddie
Copy link
Collaborator

Huddie commented Mar 11, 2019

Just for reference @viktorasl want to upload a gif with this working. It’s typically good to have a visual representation of visual design changes attaches to PR.

Sent with GitHawk

@Huddie Huddie added the 🏁 ready to pull Pull Request is ready to merge label Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏁 ready to pull Pull Request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants