-
Notifications
You must be signed in to change notification settings - Fork 13
AutoComplete Feature Test. #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Files Created : AutoComplete.js AutoComplete Component. Based on current input check with list fo branches passed as props from parent. Based on closest match suggestion is shown in terminal. useInput hook utilized to auto update value. Updated Files : DeleteBranch.js Replaced text Component with AutoComplete Component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted some comments, but the core functionality looks good! Maybe you can also add the AutoComplete functionality to the Checkout Branch as well?
Co-authored-by: Yosef Herskovitz <34112131+H3RSKO@users.noreply.github.com>
Co-authored-by: Yosef Herskovitz <34112131+H3RSKO@users.noreply.github.com>
Co-authored-by: Yosef Herskovitz <34112131+H3RSKO@users.noreply.github.com>
Removed single quotes (') from the format for git call for branches. Ensures user does not have to type out the single quote.
Seperated the list of branchs with '|' to make the list more readable.
|
Hi @H3RSKO Added the requested comments to code Added some updates to the commit as well. Please review them and let me know if any changes are required. |
|
On a side not I would like to improve the functionality of the AutoComplete component. If I could generate a list of suggestions instead of a singular option and one the press of the up or down key iterate through the generated list. The list could be sorted using levenshtein distance compared with the user input. Let me know if I should work on this. I would like to work on it. |
|
Hi @H3RSKO could you merge the request if all is correct? |
Files Created : AutoComplete.js
AutoComplete Component.
Based on current input check with list fo branches passed as props from parent. Based on closest match suggestion is shown in terminal. useInput hook utilized to auto update value.
Updated Files : DeleteBranch.js
Replaced text Component with AutoComplete Component