Skip to content

fix: make "Secret in Secrets Manager" more consistent #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agateau-gg
Copy link
Collaborator

Context

In ggshield text output, the value for the "Known by GitGuardian dashboard" is "YES" or "NO", but the value for the new "Secret in Secrets Manager" is "true" or "false".

What has been done

This commit makes "Secret in Secrets Manager" use "YES" or "NO" too.

Before:

>> Secret detected: Generic Password
   Validity: No Checker
   Occurrences: 1
   Known by GitGuardian dashboard: NO
   Incident URL: N/A
   Secret SHA: bcab461d00a692b05add54f547d83660290e1a22504db841d7a9c325451bf20b
   Secret in Secrets Manager: False
   Detector documentation: https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password

After:

>> Secret detected: Generic Password
   Validity: No Checker
   Occurrences: 1
   Known by GitGuardian dashboard: NO
   Incident URL: N/A
   Secret SHA: bcab461d00a692b05add54f547d83660290e1a22504db841d7a9c325451bf20b
   Secret in Secrets Manager: NO
   Detector documentation: https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password

In ggshield text output, the value for the "Known by GitGuardian dashboard"
is "YES" or "NO", but the value for the new "Secret in Secrets Manager" is
"true" or "false".

This commit makes "Secret in Secrets Manager" use "YES" or "NO" too.
@agateau-gg agateau-gg requested a review from a team as a code owner May 28, 2025 16:25
@agateau-gg agateau-gg requested a review from amascia-gg May 28, 2025 16:25
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (9a6a393) to head (538facf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   91.90%   91.91%           
=======================================
  Files         144      144           
  Lines        6091     6094    +3     
=======================================
+ Hits         5598     5601    +3     
  Misses        493      493           
Flag Coverage Δ
unittests 91.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant