PR: Branch Merge #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update copyright notice regex to match CLAUDE.md specification * Enable linting, fix copyright header validation, auto-fix linting errors. * Refactor error handling in get_dynamic_dependencies to provide clearer context on exceptions * Format error message in get_dynamic_dependencies for improved readability * Fix copyright headers * Remove unnecessary blank lines in test files to improve code cleanliness * Refactor copyright header in span_processor.py for clarity and compliance --------- Co-authored-by: Johan Broberg <johanb@microsoft.com>
* Initial plan * Add support for custom MCP server URLs Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Add comprehensive tests for custom MCP server URL support Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Remove unnecessary hasattr check in exception handler Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Simplify custom URL checks by removing redundant strip calls Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Improve exception handling and clarify test comments Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Refactor to consistently store URLs in the url field Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Use 'url' field consistently in both manifest and gateway responses Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Refactor gateway parsing to match manifest logic and improve variable naming Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Fix formatting: remove extra blank line in test Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Rename custom_url to endpoint for better clarity Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Remove fallback logic and use config.url directly in all tool registration services Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Remove redundant null check for server_url in Agent Framework service Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Use 'or' operator for cleaner fallback logic in server_name assignment Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Add clarifying comment for server_name fallback logic Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Fix undefined variable reference in log statement Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Move server_name assignment outside try block to ensure it's always available in exception handler Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Clarify comment for server_name fallback logic Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Add server_name fallback logic in OpenAI MCP tool registration service Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Improve variable naming consistency and add server_name fallback in Semantic Kernel service Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Fix inconsistent server_name usage in Semantic Kernel service Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Add server_name fallback logic in configuration service URL construction Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Run ruff formatter to fix formatting issues Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> * Update tests/tooling/test_mcp_server_configuration.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/tooling/test_mcp_server_configuration.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/tooling/test_mcp_server_configuration.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> Co-authored-by: Johan Broberg <johan@pontemonti.net> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…mcp_server_configuration.py (#138) Co-authored-by: Johan Broberg <johanb@microsoft.com>
…ries (#133) * Update CODEOWNERS to include tooling approvers for additional directories * Update .github/CODEOWNERS Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Johan Broberg <johanb@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add PRD for Open AI chat history API * Rename `send_chat_history_async` to `send_chat_history_messages_async` and update PRD to reflect new method naming conventions and functionality. * Add tasks for OpenAI `send_chat_history_messages_async` API implementation * Implement API for OpenAI chat history * Add comments to clarify error handling in namespace package finder --------- Co-authored-by: Johan Broberg <johanb@microsoft.com>
* fix(agentframework): address code review comments CRM-003 and CRM-004
- CRM-003: Add turn_context validation in send_chat_history_async method
to ensure fail-fast behavior and consistency with docstring
- CRM-004: Document empty message filtering behavior in _convert_chat_messages_to_history
docstring and elevate log level from DEBUG to WARNING when messages are skipped
Note: CRM-001 and CRM-002 (copyright header format) are not applicable because
the existing format ("Microsoft. All rights reserved.") is required by the
pyproject.toml linter configuration (notice-rgx), while CLAUDE.md specifies a
different format. The linter-enforced format takes precedence to ensure CI passes.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: update copyright notices to reflect Microsoft Corporation and include license information
* fix(mcp_tool_registration_service): add warning for messages with missing role during conversion
* Code review fixes/pr 132 (#134)
* refactor(agentframework): remove _async suffix from method names (CRM-010)
Rename methods to follow Python conventions and codebase patterns:
- send_chat_history_messages_async -> send_chat_history_messages
- send_chat_history_async -> send_chat_history_from_store
Rename test file accordingly:
- test_send_chat_history_async.py -> test_send_chat_history.py
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(agentframework): improve role handling and logging (CRM-003, CRM-009, CRM-013)
- CRM-003: Add defensive handling for role value access using hasattr check
- CRM-009: Convert debug and warning logging to lazy format (% style)
- CRM-013: Simplify redundant empty content check (remove `not content or`)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* test(agentframework): add missing test coverage (CRM-001, 004, 005, 006, 011, 012)
- CRM-001: Add test for ChatMessageStore exception propagation
- CRM-004: Add test for whitespace-only content filtering
- CRM-005: Add test for None role handling
- CRM-006: Add test for all messages filtered out scenario
- CRM-011: Add test for default ToolOptions creation
- CRM-012: Make UUID assertion more robust using uuid.UUID()
Also adds test for defensive role handling (string role without .value)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(tooling): return success for empty chat history list (CRM-008)
The core send_chat_history method now returns OperationResult.success()
for empty lists instead of raising ValueError. This is consistent with
the extension behavior and makes the API more forgiving.
Updated test to verify new behavior.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs(agentframework): add Chat History API documentation (CRM-002)
Update design.md to include:
- send_chat_history_messages and send_chat_history_from_store methods
- Parameter tables for both methods
- Integration flow diagram showing message conversion
- Message filtering behavior documentation
- Example usage code
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add async method naming convention to CLAUDE.md (CRM-010)
Document that _async suffix should NOT be used on async methods in this
SDK since we only provide async versions. This prevents future naming
inconsistencies.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Branch merger. Keeping code up-to-date.