Rado travis test #52
Open
Rado travis test #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usernamealreadyis
commented
Feb 1, 2016
usernamealreadyis
commented
In the `TemplateCompiler` phase, avoid reading in the `.ng_meta.json` files of imported libraries when we can determine that the file we are processing does not define any `View`s. Closes #6183
…ders used
With providers split into bundles, the test injector is now able to
use providers for a given bundle. Suggested provider lists for tests are
available in `angular2/platform/testing/<platform>`.
Change the providers for a test suite using `setBaseTestProviders`. This
should be done once at the start of the test suite, before any test cases
run.
BREAKING CHANGE: Tests are now required to use `setBaseTestProviders`
to set up. Assuming your tests are run on a browser, setup would change
as follows.
Before:
```js
// Somewhere in test setup
import {BrowserDomAdapter} from 'angular2/src/platform/browser/browser_adapter';
BrowserDomAdapter.makeCurrent
```
After:
```js
// Somewhere in the test setup
import {setBaseTestProviders} from 'angular2/testing';
import {
TEST_BROWSER_PLATFORM_PROVIDERS,
TEST_BROWSER_APPLICATION_PROVIDERS
} from 'angular2/platform/testing/browser';
setBaseTestProviders(TEST_BROWSER_PLATFORM_PROVIDERS,
TEST_BROWSER_APPLICATION_PROVIDERS);
```
Closes #5351, Closes #5585
Closes #5975
And enable transformers on all playground apps Closes #6013
Previously we grepped all hand-written Dart code and ran analyzer in strong mode against it. Now we run it against transformed playground apps, which: 1. does not analyze unnecessary code (we primarily care about stuff that runs in the browser) 2. analyzes generated code, which does run in the browser and which we failed to analyze in the previous version of the build Closes #6436
Replace uses of `package:code_transformers`, which is only used to convert from uri to `AssetId`, with calls to the utility methods in `src/transform/common/url_resolver.dart`. Closes #5931
Widen version dependencies for `package:angular`, `package:code_transformers`, and `package:observe`. `package:guinness` uses `package:unittest` while the newest versions of `package:code_transformers` use `package:test`. This causes our end-to-end Dart transformer tests (which use testing code in `package:code_transformers`) to be skipped. To fix this: - Move e2e tests to run in a separate file - Run `gulp test.server.dart` tests serially Closes #5922 Closes #5935
Task is test.unit.js.sauce, not test.unit.js.saucelabs. Closes #6435
Align the package.json license with the LICENSE file from the repo Closes #6432
Closes #6478
The newest version of the analyzer emits hints when it encounters TODOs in code, which is breaking the Dart dev version of our build. Ignore TODOs for the purpose of build health. See #6410
This only runs the JS build (no tests) as an easy place to start. Green build on my branch: https://circleci.com/gh/alexeagle/angular/5 Note, we are just experimenting with Circle at this point... Closes #6520
Resolve all invalid field override errors, workaround current reflection limitations in Dart Dev Compiler. todo, hello_world and key_events samples now work with Dart Dev Compiler. BREAKING CHANGE: remove TemplateRef.elementRef setter Closes #6441
it was previously used by benchpress (see d02c0ac) but that's no longer the case. I also removed a bunch of extranous dependencies that should never have been part of node_modules (npm bug?)
Mark says that karma-runner/karma#1768 is resolved in 0.13.17
…de instructions Closes #6213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
27 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.