Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming classes #57

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Renaming classes #57

merged 6 commits into from
Aug 19, 2024

Conversation

rabah-khalek
Copy link
Contributor

@rabah-khalek rabah-khalek commented Aug 19, 2024

we're still following different conventions for models and class:

  • XModel
  • DataLoaderX

but for now I kept it like this to ensure backward compatibility with the landmark detection module

Copy link
Collaborator

@bmalezieux bmalezieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rabah-khalek rabah-khalek merged commit f44ba9d into main Aug 19, 2024
3 of 5 checks passed
@rabah-khalek rabah-khalek deleted the renaming-classes branch August 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants