Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test face detection model using face landmark datasets #47

Merged
merged 37 commits into from
Aug 8, 2024
Merged

Test face detection model using face landmark datasets #47

merged 37 commits into from
Aug 8, 2024

Conversation

Inokinoki
Copy link
Member

@Inokinoki Inokinoki commented Jul 26, 2024 •
edited
Loading

Use landmark datasets to scan with face detection models.

@Inokinoki Inokinoki marked this pull request as ready for review July 26, 2024 16:55
@github-actions github-actions bot removed the Lockfile label Aug 5, 2024
Base automatically changed from object-detection to main August 7, 2024 14:06
@github-actions github-actions bot removed the Lockfile label Aug 7, 2024
rabah-khalek
rabah-khalek approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment

giskard_vision/object_detection/dataloaders/loaders.py Outdated Show resolved Hide resolved
@Inokinoki Inokinoki enabled auto-merge (squash) August 7, 2024 14:50
@Inokinoki Inokinoki disabled auto-merge August 7, 2024 14:54
Inokinoki and others added 17 commits August 7, 2024 17:04
@Inokinoki
Simplify meta in DataLoaderFFHQFaceDetection by popping face rectan…
c063456 
…gles
@rabah-khalek
Merge branch 'main' into face-detection-exp-inoki
c8d0ac4
@Inokinoki
Wrap metadata to fix failed notebooks
d879d1a
@Inokinoki
Merge branch 'face-detection-exp-inoki' of github.com:Giskard-AI/gisk…
13e49f9 
…ard-vision into face-detection-exp-inoki
@Inokinoki
Cleanup device="mps" to fix warning in CI
b69443a
@Inokinoki
Wrap None metadata when nothing is returned
f4ca865
@Inokinoki
Attempt to fix notebooks
51755f6
@Inokinoki
Revert "Attempt to fix notebooks"
a9b5b29 
This reverts commit 51755f6.
@Inokinoki
Fix batch in dataloader
b9a2473
@Inokinoki
Fix batch with empty dict in dataloader
92220b6
@Inokinoki
Rename to load datasets to avoid import conflicts
912a0d6
@Inokinoki
Remove unused and broken CachedDataLoader import
ba1055f
@Inokinoki
Keep MetaData class in get_single_element
496a3c6
@Inokinoki
Format code
7f0121f
@Inokinoki
Fix key error in SixDRepNet_benchmark.ipynb
de57092
@Inokinoki
Fix misunderstood meta in DataLoaderFFHQFaceDetectionLandmark
70c16a5
@Inokinoki
Fix misunderstood meta in ffhq
485d5e1
rabah-khalek
rabah-khalek approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Inokinoki

@rabah-khalek rabah-khalek merged commit ee3e294 into main Aug 8, 2024
5 checks passed
@rabah-khalek rabah-khalek deleted the face-detection-exp-inoki branch August 8, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabah-khalek rabah-khalek rabah-khalek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inokinoki @rabah-khalek