Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Banner.js #192

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update Banner.js #192

wants to merge 1 commit into from

Conversation

afaquewasim
Copy link

I solve your Issue. Please check and Accept pull request.

Manvityagi
Manvityagi requested changes Jun 20, 2021
View reviewed changes
Copy link
Member

@Manvityagi Manvityagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have changed it only for the mobile view.
Also, on several view-ports, the blue line under the text is misplaced, that needs to be fixed too.
image

@Manvityagi
Copy link
Member

The new tagline is shorter than the original one, so the blue line under the text is misplacing on several viewports, after changing the text. The PR should also address that issue and make sure that the blue line is always just under the word "Skill", See the ideal behavior in the original website by resizing the view-ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manvityagi Manvityagi Manvityagi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afaquewasim @Manvityagi