restore v0.4 behavior on v0.5, fixes #880

also add test for histogram with density=true
GiovineItalia · Aug 24, 2016 · b9e8975 · b9e8975
1 parent 4a36837
commit b9e8975
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/statistics.jl b/src/statistics.jl
@@ -327,7 +327,7 @@ function apply_statistic(stat::HistogramStatistic,
             x_min = Gadfly.concrete_minimum(values)
             span = x_max - x_min
             binwidth = span / d
-            bincounts ./= sum(bincounts) * binwidth
+            bincounts = bincounts ./ sum(bincounts) * binwidth
         end
 
         binwidth = (x_max - x_min) / d
@@ -384,7 +384,7 @@ function apply_statistic(stat::HistogramStatistic,
 
             if stat.density
                 binwidth = x_span / d
-                bincounts ./= sum(bincounts) * binwidth
+                bincounts = bincounts ./ sum(bincounts) * binwidth
             end
 
             stack_height += bincounts[1:d]

diff --git a/test/histogram_density.jl b/test/histogram_density.jl
@@ -0,0 +1,5 @@
+using Gadfly, RDatasets
+
+# see issue #880
+plot(dataset("ggplot2", "diamonds"), x="Price", color="Cut",
+                   Geom.histogram(bincount=30, density=true))