Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add support for always_on option for shout output #355

Closed
vari opened this issue Dec 8, 2023 · 3 comments · Fixed by #358
Closed

[Enhancement] Add support for always_on option for shout output #355

vari opened this issue Dec 8, 2023 · 3 comments · Fixed by #358
Assignees
Labels
enhancement New feature or request feature coverage Coverage for a feature from the upstream project

Comments

@vari
Copy link

vari commented Dec 8, 2023

As per the MPD docs, it is possible to set the always_on flag for all output plugins.

It would be great if we can add another env variable for the shout plugin which lets users specify the value for always_on for shout output. Looking at the build_additional.sh script, it seems like this should be a one line code change.

In terms of defaults, I think yes would make sense since shout is typically used for streaming to Icecast/shoutcast and hence having always on is a reasonable default (to ensure the stream is always active).

Additionally, it would be great if we could consider adding an environment variable which will disable the default generation of the mpd.conf file so that users can supply their own mpd.conf file if desired (which should future proof things/provide a workaround for any options that cannot be set via env vars currently)

@vari vari changed the title Add support for always_on option for shout output [Feature] Add support for always_on option for shout output Dec 8, 2023
@vari vari changed the title [Feature] Add support for always_on option for shout output [Enhancement] Add support for always_on option for shout output Dec 8, 2023
@GioF71 GioF71 added the enhancement New feature or request label Dec 8, 2023
@GioF71 GioF71 self-assigned this Dec 8, 2023
@GioF71
Copy link
Owner

GioF71 commented Dec 8, 2023

Hello, please try one of the images here

About the other request, you are not the first to ask this, but I never agreed to the change. Thinking again, maybe one variable specifiying the user-provided config file is an easy change.
The whole purpose of this container image is to NOT having to build your own mpd.conf file but instead to instruct to script to do that for us.
But yes, I will do that after all, please open a separate issue so we can keep track of the changes.

What has always stopped me from doing that is the possibility to receive, after the change, complaints for non working configurations. MPD is quite articulate in its configuration.

@vari
Copy link
Author

vari commented Dec 8, 2023

The image you linked worked! Thanks for the quick response 😄

I created #356 for providing a custom mpd.conf file.

I understand and agree with your rationale of avoiding complaints for non-working configurations, but I think if you preface the docs regarding the new environment variable to explicitly say "use at own risk" / only use if no other existing env vars work for your use case, you may be able to avoid most of the complaints. I like the idea of having it as a backup option, just in case it is needed but definitely don't see it as the primary way people should be using this container.

@GioF71 GioF71 added the feature coverage Coverage for a feature from the upstream project label Dec 9, 2023
@GioF71
Copy link
Owner

GioF71 commented Dec 9, 2023

Branch merged, new images building now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature coverage Coverage for a feature from the upstream project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants