Remove Asrt.Star (fix #159) #316
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if you fix this problem, it will also fix #301 |
giltho
reviewed
Oct 10, 2024
| @@ -1,15 +1,19 @@ | |||
| (** {b GIL logic assertions}. *) | |||
| type t = TypeDef__.assertion = | |||
| type simple = TypeDef__.assertion_simple = | |||
There was a problem hiding this comment.
Can we call this type atom?
Ah yes interesting you seem to have stumbled upon similar things... When I have more time (🫠) I'll look; what's odd is that the version that works doesn't sort the assertions, so I'm not certain how sorting then (Types>Pure>CorePred>Wand) causes the issue; will update And yes sure I'll rename it to Additional note: running Gillian-JS with this causes a stack overflow so something somewhere isn't tail-recursive anymore... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Asrt.Star; what used to beAsrt.tis nowAsrt.simple(atomic assertions), andAsrt.tis nowsimple list, avoiding the need for recursive functions when traversing assertions, and making the distinction much clearer and simpler.Rename
Asrt.GA->Asrt.CorePredCurrently works but AWS with Gillian-C fails, because the ordering of assertions is pre/post-conditions is different so something weird happens, I need to investigate a bit but opening the PR as draft in case anyone wants to peek :p