Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add consume & produce commands #309

Merged
merged 1 commit into from
Aug 15, 2024
Merged

add consume & produce commands #309

merged 1 commit into from
Aug 15, 2024

Conversation

giltho
Copy link
Contributor

@giltho giltho commented Aug 8, 2024

Signed-off-by: Sacha Ayoun sachaayoun@gmail.com

@giltho
add consume & produce commands
2d570a7 
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
N1ark
N1ark approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@N1ark N1ark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

would be nicer to define some shared function for consume + SepAssert but if it's a temporary thing it doesn't really matter

(edit: oops i forgot i dont have approval rights)

@giltho
Copy link
Contributor Author

giltho commented Aug 8, 2024

would be nicer to define some shared function for consume + SepAssert

I tried but didn’t quite work, the two functions return different things, I’d need to return a substitution etc… it could be done but it’s not a clean cut

@giltho giltho merged commit b7e4658 into master Aug 15, 2024
9 checks passed
@giltho giltho deleted the inh-ex branch August 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N1ark N1ark N1ark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giltho @N1ark