Skip to content

Move to a logging framework#31

Closed
e3ndr wants to merge 1 commit intoGikkman:masterfrom
Casterlabs:master
Closed

Move to a logging framework#31
e3ndr wants to merge 1 commit intoGikkman:masterfrom
Casterlabs:master

Conversation

@e3ndr
Copy link
Contributor

@e3ndr e3ndr commented Oct 8, 2020

Also make verbosity a log level instead of a boolean.

This allows us to silence all output from Twirk (Our console window currently looks like this)

Also make verbosity a log level instead of a boolean.

This allows us to silence all output from Twirk.
@Gikkman
Copy link
Owner

Gikkman commented Oct 14, 2020

Hi!

Sorry for the slow response! I hadn't seen this PR for some reason. I'll go ahead and test it out soon and get back to you.

Thank you for your effort!

@Gikkman
Copy link
Owner

Gikkman commented Nov 7, 2020

Hi again!

I tested the code you suggested, and it works just as it should 👍 However, I received a message from some users of the library who mentioned backwards compatibility. Not everyone uses JUL, and some redirect System.out.println to their own custom methods for handling.

So instead, I used a lot of what you've done here and implemented a solution where you can provide your onw log methods to the TwirkBuilder, and those will then be called whenever a log message of a certain severity occurs. This is the most backwards compatible I can come up with, while still giving you and everyone using a log framework the ability to set your own logging methods.

You can see the implementation I went for in the 0.6.3 branch

Thank you for your effort!

@Gikkman Gikkman closed this Nov 7, 2020
@e3ndr e3ndr deleted the master branch May 9, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants