-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS support #1732
OS support #1732
Conversation
Make DockStarter work with CoreOS (immutable filesystem, no traditional package manager)
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
The only thing I'm not a fan of is no longer providing the user the link for how to install compose. |
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Yeah I thought a bit about removing that and decided it would be nice to keep it the same as the others in terms of wording and verbosity. Technically there are many ways one could install compose as well as any of the other dependencies. |
That page gives a bunch of different options. Including the exact command you need on coreos. |
If you use two targets for home, if either isn't in the path, it looks like it will warn even if nothing is wrong and it would work fine. |
Can we add the docker compose doc I linked to the readme at least? It's probably exactly what the user needs to do. |
This is true. I also found many OS don't include
I am definitely fine with the link being added to the readme with a description somewhere, and I'm not dead set that it can't be included in the failing command output, but maybe it would be cleaner as a maybe if ! docker compose version > /dev/null 2>&1; then
warn "Please see https://docs.docker.com/compose/install/linux/ to install 'docker compose'"
fatal "Error: 'docker compose' is not available. Please install 'docker compose' and try again."
fi |
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Pull request
Purpose
Follow up from #1731 to make DS compatible with CoreOS (or any OS where a supported package manager is not detected.
Approach
This results in DS exiting with a
fatal
when any required dependency is missing (and a supported package manager is not found to install the dependency) and informing the user that they need to install said dependency manually.Requirements
Check all boxes as they are completed