feat: 💥 new environment and volume var naming #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
nemchik
force-pushed
the
variable-naming
branch
4 times, most recently
from
1e4f054
to
76dc44d
Compare
Signed-off-by: Eric Nemchik <eric@nemchik.com>
nemchik
force-pushed
the
variable-naming
branch
from
76dc44d
to
a829ea2
Compare
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
This was referenced Feb 20, 2024
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Fix `PLEX_ENVIRONMENT_CLAIM` TO `PLEX_ENVIRONMENT_PLEX_CLAIM`
Add the missing `gluetun` variables and ports, set to the defaults listed in the gluetun wiki.
Change sorting of variables to sort using lower case, so that `_` sorts to the top. This will allow using variables starting with `_` in other variable definitions, such as `VAR="This expands ${_VAR2}"`.
A variable must be defined BEFORE being expanded in another variable.
Fix linting
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
3 tasks
Remove extra newline at end of `.env.example`, add the newline in the app headings instead. Fix up naming of variables slightly. Select a heading format instead of the heading itself when looping between `BUILTIN` and `USER_DEFINED` headings.
Disable shellcheck error for variable in printf format string
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Co-authored-by: Eric Nemchik <eric@nemchik.com>
Co-authored-by: Eric Nemchik <eric@nemchik.com>
Remove `APPFOLDER` variable. Remove commented `debug` line.
Add "APPNAME" headings in `.env`, and move the "migrate" logic into `appvars_create.sh`
CLHatch
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Purpose
<appname>_<section>_<varname>where<section>is new and mostly made up of eitherENVIRONMENTorVOLUMEVOLUMEvariables in scriptsAPPNAME_prefixed variablesloggingsections from all app templates (this simplifies the compose file and allows the user to configure a global default on their own or override individual apps easier)_from appnamesRequirements
Check all boxes as they are completed