API 2.9.4: Fix Bundle Fullness predicate, expose playFabId in GeyserConnection#6190
Merged
onebeastchris merged 5 commits intomasterfrom Feb 16, 2026
Merged
API 2.9.4: Fix Bundle Fullness predicate, expose playFabId in GeyserConnection#6190onebeastchris merged 5 commits intomasterfrom
onebeastchris merged 5 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR targets the 2.9.4 API release by correcting the bundleFullness range-dispatch predicate behavior/signature and exposing the player’s PlayFab ID through the public GeyserConnection API, while also relaxing a custom-item vanilla model override restriction.
Changes:
- Bump version to
2.9.4-SNAPSHOT. - Fix
bundleFullnesspredicate threshold handling by moving to adouble-based API (with a deprecatedintoverload). - Expose
playFabIdviaGeyserConnection/GeyserSessionand plumb it through login/auth data; allow vanilla model override without predicates (warn instead of throw).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Version bump to 2.9.4 snapshot. |
| core/src/main/java/org/geysermc/geyser/util/LoginEncryptionUtils.java | Populate AuthData with PlayFab ID from login identity claims. |
| core/src/main/java/org/geysermc/geyser/session/auth/BedrockClientData.java | Remove PlayFabId field from client data parsing. |
| core/src/main/java/org/geysermc/geyser/session/auth/AuthData.java | Extend auth record to carry playFabId. |
| core/src/main/java/org/geysermc/geyser/session/GeyserSession.java | Implement new GeyserConnection#playFabId() accessor. |
| core/src/main/java/org/geysermc/geyser/registry/populator/CustomItemRegistryPopulator.java | Warn (instead of error) when overriding vanilla model without predicates. |
| core/src/main/java/org/geysermc/geyser/registry/mappings/predicate/ItemRangeDispatchProperty.java | Treat single-arg range dispatch creators as double thresholds. |
| core/src/main/java/org/geysermc/geyser/registry/loader/ProviderRegistryLoader.java | Pass bundle_fullness threshold as double when creating predicates. |
| api/src/main/java/org/geysermc/geyser/api/predicate/item/RangeDispatchPredicate.java | Update BUNDLE_FULLNESS docs to reflect fullness semantics. |
| api/src/main/java/org/geysermc/geyser/api/predicate/item/ItemRangeDispatchPredicate.java | Deprecate int overload; add double overload for bundle fullness. |
| api/src/main/java/org/geysermc/geyser/api/connection/GeyserConnection.java | Add playFabId() to the public connection API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
api/src/main/java/org/geysermc/geyser/api/predicate/item/ItemRangeDispatchPredicate.java
Show resolved
Hide resolved
api/src/main/java/org/geysermc/geyser/api/predicate/item/ItemRangeDispatchPredicate.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/geysermc/geyser/api/predicate/item/RangeDispatchPredicate.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/geysermc/geyser/api/connection/GeyserConnection.java
Show resolved
Hide resolved
zxclimon
pushed a commit
to zxclimon/GeyserFork
that referenced
this pull request
Feb 17, 2026
…onnection (GeyserMC#6190) * API 2.9.4 * Deprecate bundleFullness(int), introduce bundleFullness(double) * Allow overriding vanilla item model without additional predicates * Expose playFabId in GeyserConnection * Address clanker review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small release primarily aimed at resolving one method introduced in version 2.9.3 (bundleFullness); and adds the playFabId to GeyserConnection. Further, this re-introduces v1 functionality which allows overriding the vanilla item model.