Skip to content

API 2.9.4: Fix Bundle Fullness predicate, expose playFabId in GeyserConnection#6190

Merged
onebeastchris merged 5 commits intomasterfrom
api/2.9.4
Feb 16, 2026
Merged

API 2.9.4: Fix Bundle Fullness predicate, expose playFabId in GeyserConnection#6190
onebeastchris merged 5 commits intomasterfrom
api/2.9.4

Conversation

@onebeastchris
Copy link
Member

This is a very small release primarily aimed at resolving one method introduced in version 2.9.3 (bundleFullness); and adds the playFabId to GeyserConnection. Further, this re-introduces v1 functionality which allows overriding the vanilla item model.

Copilot AI review requested due to automatic review settings February 15, 2026 19:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets the 2.9.4 API release by correcting the bundleFullness range-dispatch predicate behavior/signature and exposing the player’s PlayFab ID through the public GeyserConnection API, while also relaxing a custom-item vanilla model override restriction.

Changes:

  • Bump version to 2.9.4-SNAPSHOT.
  • Fix bundleFullness predicate threshold handling by moving to a double-based API (with a deprecated int overload).
  • Expose playFabId via GeyserConnection/GeyserSession and plumb it through login/auth data; allow vanilla model override without predicates (warn instead of throw).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
gradle.properties Version bump to 2.9.4 snapshot.
core/src/main/java/org/geysermc/geyser/util/LoginEncryptionUtils.java Populate AuthData with PlayFab ID from login identity claims.
core/src/main/java/org/geysermc/geyser/session/auth/BedrockClientData.java Remove PlayFabId field from client data parsing.
core/src/main/java/org/geysermc/geyser/session/auth/AuthData.java Extend auth record to carry playFabId.
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java Implement new GeyserConnection#playFabId() accessor.
core/src/main/java/org/geysermc/geyser/registry/populator/CustomItemRegistryPopulator.java Warn (instead of error) when overriding vanilla model without predicates.
core/src/main/java/org/geysermc/geyser/registry/mappings/predicate/ItemRangeDispatchProperty.java Treat single-arg range dispatch creators as double thresholds.
core/src/main/java/org/geysermc/geyser/registry/loader/ProviderRegistryLoader.java Pass bundle_fullness threshold as double when creating predicates.
api/src/main/java/org/geysermc/geyser/api/predicate/item/RangeDispatchPredicate.java Update BUNDLE_FULLNESS docs to reflect fullness semantics.
api/src/main/java/org/geysermc/geyser/api/predicate/item/ItemRangeDispatchPredicate.java Deprecate int overload; add double overload for bundle fullness.
api/src/main/java/org/geysermc/geyser/api/connection/GeyserConnection.java Add playFabId() to the public connection API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@onebeastchris onebeastchris merged commit 0aa7f22 into master Feb 16, 2026
3 checks passed
@onebeastchris onebeastchris deleted the api/2.9.4 branch February 16, 2026 16:09
zxclimon pushed a commit to zxclimon/GeyserFork that referenced this pull request Feb 17, 2026
…onnection (GeyserMC#6190)

* API 2.9.4

* Deprecate bundleFullness(int), introduce bundleFullness(double)

* Allow overriding vanilla item model without additional predicates

* Expose playFabId in GeyserConnection

* Address clanker review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant