Fix: Normalized damage / count should have a double, not int threshold#6188
Merged
onebeastchris merged 1 commit intoGeyserMC:masterfrom Feb 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes creation of normalized range-dispatch predicates so the threshold is treated as a double (matching the API contract) instead of being handled as an int, preventing type mismatch/runtime cast issues when using normalized damage/count predicates.
Changes:
- Update
RangeDispatchPredicate.Property.DAMAGEnormalized predicate construction to pass adoublethreshold. - Update
RangeDispatchPredicate.Property.COUNTnormalized predicate construction to pass adoublethreshold.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zxclimon
pushed a commit
to zxclimon/GeyserFork
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://discord.com/channels/613163671870242838/1472225393942593683/1472225496832938201 for context