Skip to content

Don't simulate entity movement when passenger#6181

Merged
onebeastchris merged 1 commit intoGeyserMC:masterfrom
AJ-Ferguson:issue-6021
Feb 12, 2026
Merged

Don't simulate entity movement when passenger#6181
onebeastchris merged 1 commit intoGeyserMC:masterfrom
AJ-Ferguson:issue-6021

Conversation

@AJ-Ferguson
Copy link
Member

Fixes #6021

Copilot AI review requested due to automatic review settings February 11, 2026 23:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where hologram items displayed incorrectly for Bedrock Edition players (issue #6021). When entities are used as passengers (e.g., items in holograms), they should not simulate their own movement. The fix prevents passenger entities from updating their positions based on motion, ensuring they remain properly positioned relative to their vehicle entity.

Changes:

  • Added vehicle checks to prevent movement simulation for passenger entities
  • Set motion to zero when entities become passengers to clear residual movement

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
JavaSetPassengersTranslator.java Sets passenger motion to zero when mounting to clear residual movement
ThrowableEntity.java Skips tick movement simulation when entity is a passenger
ItemEntity.java Skips tick movement simulation when entity is a passenger
FishingHookEntity.java Skips tick movement simulation when entity is a passenger
FireballEntity.java Skips tick movement simulation when entity is a passenger

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@onebeastchris onebeastchris merged commit e9975ef into GeyserMC:master Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with displaying item in the holograms of the DecectHolograms plugin

2 participants