Don't simulate entity movement when passenger#6181
Merged
onebeastchris merged 1 commit intoGeyserMC:masterfrom Feb 12, 2026
Merged
Don't simulate entity movement when passenger#6181onebeastchris merged 1 commit intoGeyserMC:masterfrom
onebeastchris merged 1 commit intoGeyserMC:masterfrom
Conversation
onebeastchris
approved these changes
Feb 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where hologram items displayed incorrectly for Bedrock Edition players (issue #6021). When entities are used as passengers (e.g., items in holograms), they should not simulate their own movement. The fix prevents passenger entities from updating their positions based on motion, ensuring they remain properly positioned relative to their vehicle entity.
Changes:
- Added vehicle checks to prevent movement simulation for passenger entities
- Set motion to zero when entities become passengers to clear residual movement
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| JavaSetPassengersTranslator.java | Sets passenger motion to zero when mounting to clear residual movement |
| ThrowableEntity.java | Skips tick movement simulation when entity is a passenger |
| ItemEntity.java | Skips tick movement simulation when entity is a passenger |
| FishingHookEntity.java | Skips tick movement simulation when entity is a passenger |
| FireballEntity.java | Skips tick movement simulation when entity is a passenger |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6021