Support for max stack size #5011
Draft
+118
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
reviewed
Sep 1, 2024
| @@ -133,12 +137,20 @@ public int getNetId() { | |||
| return isEmpty() ? 0 : netId; | |||
| } | |||
|
|
|||
| public void add(int add) { | |||
| public int capacity() { | |||
There was a problem hiding this comment.
Add Javadoc here please - seems straightforward but took me a minute so let's be super clear.
There was a problem hiding this comment.
or rename it to remainingCapacity/remainingSize?
i would expect capacity == maxStackSize because of typical capacity meaning (if thats what you meant too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs more testing and support for survival mode.
Creative mode should be fully supported