Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for max stack size #5011

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AJ-Ferguson
Copy link
Member

Still needs more testing and support for survival mode.
Creative mode should be fully supported

@@ -133,12 +137,20 @@ public int getNetId() {
return isEmpty() ? 0 : netId;
}

public void add(int add) {
public int capacity() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Javadoc here please - seems straightforward but took me a minute so let's be super clear.

Copy link
Member

@Konicai Konicai Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or rename it to remainingCapacity/remainingSize?

i would expect capacity == maxStackSize because of typical capacity meaning (if thats what you meant too)

@onebeastchris onebeastchris linked an issue Sep 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Place Armor Stands and Cakes
3 participants