-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Extensions should specify geyser api version instead of base api version #3880
Fix: Extensions should specify geyser api version instead of base api version #3880
Conversation
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
Bumping the base api version seems to have fixed building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project lead needs to take a look at this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides these comments I'd remove the major,minor,patch fields of GeyserExtensionDescription and use ApiVersion there as well
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # api/src/main/java/org/geysermc/geyser/api/GeyserApi.java # core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java # gradle/libs.versions.toml
api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java
Outdated
Show resolved
Hide resolved
api/src/main/java-templates/org.geysermc.geyser.api.util/BuildData.java
Outdated
Show resolved
Hide resolved
|
) * let extensions specify geyser api version instead of base api version * fix spacing, @link formatting, properly check for compat * Proper warning, update to API changes to also check patch version * Bump base-api version * adapt to new base api changes * Actually bump to 2.4.1 * Update api/src/main/java/org/geysermc/geyser/api/extension/ExtensionDescription.java * Address reviews * Address reviews * Update to latest base api changes; proper extension *human* version checking * no need to apply a plugin, that's the default --------- Co-authored-by: Konicai <71294714+Konicai@users.noreply.github.com>
Relies on GeyserMC/api#2
Changes: