Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make above-bedrock-nether-building option a player preference #3685

Conversation

axieum
Copy link

@axieum axieum commented Apr 18, 2023

Hi, 👋

This adds the above-bedrock-nether-building option to the players' preferences.

Things not addressed in this PR:

  • The option has to be toggled on every login - I suggest saving players' preferences with the Floodgate database(?)
  • It defaults to off for each player, perhaps we add a new option in the server config to change this too(?)

Thanks,

@onebeastchris onebeastchris added PR: Feature When a PR implements a new feature Waiting On Response When an issue or PR is waiting on a response from a [specific] person. labels May 23, 2023
@Konicai Konicai removed the Waiting On Response When an issue or PR is waiting on a response from a [specific] person. label May 24, 2023
@matsyyy
Copy link

matsyyy commented Jul 8, 2023

is this ever going to be merged or not?
very cool to not have any response from devs for over 2 months now.. if there is some issue with the PR, please do tell us, if not, what is the reason for it going stale?

@Camotoy
Copy link
Member

Camotoy commented Jul 9, 2023

It's nothing to do with the PR specifically... it's just not an ideal situation to be in at all and adding to a bad situation. Ideally we don't even need a workaround at all but we don't have that option. I think there was some internal discussion some days ago about this and I'll try to get those forwarded here.

@onebeastchris
Copy link
Member

Hey! Thanks for the PR. Unfortunately, given the current setup of preferences where they aren't saved for users - and the hacky nature of our workaround - we feel like this isn't currently a fit for Geyser at the moment. Thanks you anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature When a PR implements a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants