Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some ping passthrough stuff #2726

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Cleanup some ping passthrough stuff #2726

merged 1 commit into from
Dec 23, 2021

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Dec 23, 2021

Mostly just some deprecated usage on BungeeCord

  • Replaced ServerPing constructor with BaseComponent instead of String for motd
  • Replaced usage of ProxyServer#getGameVersion()

On Spigot, decided to return a null GeyserPingInfo instead of one with empty data, since Geyser seems to always check for null GeyserPingInfo, but not always its data components.

Only tested BungeeCord to make sure motd and version passthrough were still the same.

@Camotoy
Copy link
Member

Camotoy commented Dec 23, 2021

Do you have time to test Spigot by just adding a if (true) throw Exception sort of thing?

@Konicai
Copy link
Member Author

Konicai commented Dec 23, 2021 •
edited
Loading

Seems fine
https://mclo.gs/kHzK5R2#L283
image

@Camotoy Camotoy merged commit 6cd8b33 into GeyserMC:master Dec 23, 2021
@Konicai Konicai deleted the better_ping branch January 24, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camotoy Camotoy Camotoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Konicai @Camotoy