Fix potential issue with Boat Data #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol would be funny if this completely fixed boats |
|
Great change, o quoter of Lincoln, but it would be rather helpful if you updated your mappings submodule. xd |
bundabrg
force-pushed
the
fix/conserve-brackets
branch
from
69d3597 to
20c73c8
Compare
|
It has been sorted. |
|
Have you tested and confirmed that boats still operate normally on 1.16.100 and 1.16.200? |
|
yep. |
Camotoy
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it was Abraham Lincoln who said that the smallest change can have the greatest impact; that being the change is an oft once in a life time opportunity and it is through trying times that hero's are born, nay forged by the fires of the challenge thrust upon them. Or it might not have been him but lets not let truth get in the way.
Gentlemen, such a time has come upon us and requires the utmost of care to solve as well as the boldest of moves. Risks must be taken but ultimately we will prevail because the human spirit is strong.
I put it out that this change is of critical importance and the very act of performing this merge may very likely be the greatest thing ever to be achieved by whomever is lucky enough to do so. You can rest your head, weary as it may be, knowing that your job is done and that it is only downhill from here.