-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for crawling and moving in one-block spaces where possible #1814
Conversation
This commit brings full support for crawling, sneaking under 1.75-block-tall spaces, and swimming in one-block areas. There is a check in place that decreases the player's speed to something comparable to Java if they are in a situation where they would otherwise go at normal walking speed (for example: without the check, a Bedrock player would go at full walking speed while crawling.
!start-test-server |
Preparing and starting test server as requested by @Camotoy at 2021-01-07 23:20:34 UTC Downloading Geyser Standalone... Finished download, setting up docker container... Built docker container. Connect via 51.210.124.95:32819 ( |
!start-test-server |
Preparing and starting test server as requested by @Camotoy at 2021-01-08 16:56:24 UTC Downloading Geyser Standalone... Finished download, setting up docker container... Built docker container. Connect via 51.210.124.95:32820 ( |
This does break swimming on 1.13.2, which, while certainly not the end of the world, is not a regression I'd like to introduce. |
You said it breaks swimming, does this mean you won't implement it without re-fixing swimming or will it be OK? |
I don't plan on merging this until there are no known regressions. |
anyway this could be added to the inventory branch? |
This branch is untested and unsupported by Geyser but it does work |
The above branch is untested and unsupported by Geyser. |
Sorry I edited it |
This PR is back in business - I realized that the client is a bit more authoritative when it comes to setting sneaking and swimming. The only downside is that, if a player unsneaks, they get stuck in the block until they sneak again, but I'm fine with that behavior/I might fix that. |
Hey, just wondering, what's the current state of this? |
I have this merged into my fork of Geyser if you want to use it now You can also download this PR from checks |
Thanks, I'm aware, that's why I know it fixes some stuff. But I meant the anti cheat I'm developing (https://www.spigotmc.org/resources/themis-anti-cheat-1-16-x-bedrock-support-paper-tuinity-compatibility-free-optimized.90766/), and I can't really tell the user they need to download some special build with this patch😅 |
This commit brings full support for crawling, sneaking under 1.75-block-tall spaces, and swimming in one-block areas. There is a check in place that decreases the player's speed to something comparable to Java if they are in a situation where they would otherwise go at normal walking speed (for example: without the check, a Bedrock player would go at full walking speed while crawling.