Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for crawling and moving in one-block spaces where possible #1814

Merged
merged 16 commits into from
Apr 12, 2021

Conversation

Camotoy
Copy link
Member

@Camotoy Camotoy commented Jan 7, 2021

This commit brings full support for crawling, sneaking under 1.75-block-tall spaces, and swimming in one-block areas. There is a check in place that decreases the player's speed to something comparable to Java if they are in a situation where they would otherwise go at normal walking speed (for example: without the check, a Bedrock player would go at full walking speed while crawling.

This commit brings full support for crawling, sneaking under 1.75-block-tall spaces, and swimming in one-block areas. There is a check in place that decreases the player's speed to something comparable to Java if they are in a situation where they would otherwise go at normal walking speed (for example: without the check, a Bedrock player would go at full walking speed while crawling.
@Camotoy Camotoy added the PR: Feature When a PR implements a new feature label Jan 7, 2021
@Camotoy
Copy link
Member Author

Camotoy commented Jan 7, 2021

!start-test-server

@geysermc-services
Copy link

geysermc-services bot commented Jan 7, 2021

Preparing and starting test server as requested by @Camotoy at 2021-01-07 23:20:34 UTC

Downloading Geyser Standalone...

Finished download, setting up docker container...

Built docker container.

Connect via 51.210.124.95:32819 (minecraft://?addExternalServer=Test%20PR%231814|51.210.124.95:32819)

@Camotoy
Copy link
Member Author

Camotoy commented Jan 8, 2021

!start-test-server

@geysermc-services
Copy link

geysermc-services bot commented Jan 8, 2021

Preparing and starting test server as requested by @Camotoy at 2021-01-08 16:56:24 UTC

Downloading Geyser Standalone...

Finished download, setting up docker container...

Built docker container.

Connect via 51.210.124.95:32820 (minecraft://?addExternalServer=Test%20PR%231814|51.210.124.95:32820)

@Camotoy
Copy link
Member Author

Camotoy commented Jan 8, 2021

This does break swimming on 1.13.2, which, while certainly not the end of the world, is not a regression I'd like to introduce.

@YHDiamond
Copy link
Contributor

You said it breaks swimming, does this mean you won't implement it without re-fixing swimming or will it be OK?

@Camotoy
Copy link
Member Author

Camotoy commented Jan 12, 2021

I don't plan on merging this until there are no known regressions.

@datrandomduggy
Copy link

anyway this could be added to the inventory branch?

@Hellohi3654
Copy link
Contributor

Hellohi3654 commented Feb 25, 2021

anyway this could be added to the inventory branch?

This branch is untested and unsupported by Geyser but it does work
https://github.com/Hellohi3654/Geyser/releases/latest

@Camotoy
Copy link
Member Author

Camotoy commented Feb 25, 2021

The above branch is untested and unsupported by Geyser.

@Hellohi3654
Copy link
Contributor

The above branch is untested and unsupported by Geyser.

Sorry I edited it

@Camotoy
Copy link
Member Author

Camotoy commented Mar 21, 2021

This PR is back in business - I realized that the client is a bit more authoritative when it comes to setting sneaking and swimming. The only downside is that, if a player unsneaks, they get stuck in the block until they sneak again, but I'm fine with that behavior/I might fix that.

@Camotoy Camotoy mentioned this pull request Mar 25, 2021
@Olexorus
Copy link

Olexorus commented Apr 6, 2021

Hey, just wondering, what's the current state of this?
It seems to fix some issues with my anti cheat, so it would be really cool to see this merged 😄

@Hellohi3654
Copy link
Contributor

Hellohi3654 commented Apr 6, 2021

Hey, just wondering, what's the current state of this?
It seems to fix some issues with my anti cheat, so it would be really cool to see this merged 😄

I have this merged into my fork of Geyser if you want to use it now

You can also download this PR from checks

@Olexorus
Copy link

Olexorus commented Apr 6, 2021

I have this merged into my fork of Geyser if you want to use it now

You can also download this PR from checks

Thanks, I'm aware, that's why I know it fixes some stuff. But I meant the anti cheat I'm developing (https://www.spigotmc.org/resources/themis-anti-cheat-1-16-x-bedrock-support-paper-tuinity-compatibility-free-optimized.90766/), and I can't really tell the user they need to download some special build with this patch😅

@Camotoy Camotoy merged commit 120769c into GeyserMC:master Apr 12, 2021
@Camotoy Camotoy deleted the boundingboxsupport branch April 12, 2021 04:37
@davchoo davchoo mentioned this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature When a PR implements a new feature
Projects
None yet
6 participants