feat: collect more granular RTC stats #1735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
thesyncim,
myandrienko,
santhoshvai and
kristian-mkd
myandrienko
approved these changes
Mar 26, 2025
Comment on lines
+5
to
+8
| string, // method name | ||
| string | null, // id | ||
| RTCStatsDataType, // payload | ||
| number, // timestamp |
There was a problem hiding this comment.
You can use TypeScript's labeled tuple elements.
private buffer: [
methodName: string,
id: string | null,
payload: RTCStatsDataType,
timestamp: number,
];| * transforms a maplike to an object. Mostly for getStats + JSON.parse(JSON.stringify()) | ||
| * @param {*} m | ||
| */ | ||
| export const map2obj = (m: Map<string, any>): Record<string, any> => { |
There was a problem hiding this comment.
I think this can be replaced with Object.fromEntries, which is widely available.
| const getStats = () => { | ||
| pc.getStats(null).then((stats) => { | ||
| const now = map2obj(stats as Map<string, any>); | ||
| const base = JSON.parse(JSON.stringify(now)); // our new prev |
There was a problem hiding this comment.
Do we need to clone here? It will be cloned in deltaCompression anyway.
| trace('ontrack', id, `${e.track.kind}:${e.track.id} ${streams}`); | ||
| }); | ||
| pc.addEventListener('signalingstatechange', () => { | ||
| trace('onsignalingstatechange', id, pc.signalingState); |
There was a problem hiding this comment.
Not sure, but I think this is a better place to dispose interval (if (pc. signalingState === 'closed')). Then pc instance can be cleaned up as soon as the connection is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the new RTC stats collection flow. Switches to
max-bundleRTCPeerConnection bundle policyImplementation notes