Skip to content

Add new users to the demo-app models#1640

Merged
aleksandar-apostolov merged 2 commits into
developfrom
chore/rahullohra/add-new-users-demo-app
Apr 9, 2026
Merged

Add new users to the demo-app models#1640
aleksandar-apostolov merged 2 commits into
developfrom
chore/rahullohra/add-new-users-demo-app

Conversation

@rahul-lohra
Copy link
Copy Markdown
Contributor

@rahul-lohra rahul-lohra commented Apr 6, 2026

Goal

Add new users to the demo-app models

Implementation

Add new users to the demo-app models

🎨 UI Changes

None

Testing

Just make a call with new user

Summary by CodeRabbit

  • New Features
    • Added three new built-in demo users to the application, each with profile information and image assets, expanding the available user options for testing and demonstration purposes.

@rahul-lohra rahul-lohra self-assigned this Apr 6, 2026
@rahul-lohra rahul-lohra added the pr:demo-app Changes specific to demo app label Apr 6, 2026
@rahul-lohra rahul-lohra requested a review from a team as a code owner April 6, 2026 13:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf8d6ff9-62ff-437c-a527-315305fae118

📥 Commits

Reviewing files that changed from the base of the PR and between 1e7e153 and 3dc1ce2.

📒 Files selected for processing (1)
  • demo-app/src/main/kotlin/io/getstream/video/android/models/Users.kt

Walkthrough

Three built-in users (rahul, pratim, gian) are added to the builtInUsers() function in the Users model, each with role = "user" and image URLs. No API signatures or control flow are modified.

Changes

Cohort / File(s) Summary
Users Model Updates
demo-app/src/main/kotlin/io/getstream/video/android/models/Users.kt
Added three new built-in User entries (rahul, pratim, gian) with role="user" and corresponding image URLs to the return list of User.Companion.builtInUsers().

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Three new friends hop into the fold,
Rahul, Pratim, and Gian, brave and bold!
With roles and images, they stand tall,
A demo team for one and all!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and largely generic. It follows the template structure but lacks detailed implementation specifics, proper testing instructions, and missing most required checklist items. Expand the Implementation section with specifics about the three new users (rahul, pratim, gian). Complete the ☑️Contributor and ☑️Reviewer Checklists. Clarify testing steps and provide more detailed context for the change.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically summarizes the main change: adding new users to demo-app models.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rahullohra/add-new-users-demo-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.02 MB 12.02 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.28 MB 6.28 MB 0.00 MB 🟢

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2026

@aleksandar-apostolov aleksandar-apostolov merged commit e3bbaf5 into develop Apr 9, 2026
13 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the chore/rahullohra/add-new-users-demo-app branch April 9, 2026 07:58
@stream-public-bot stream-public-bot added the released Included in a release label Apr 23, 2026
@stream-public-bot
Copy link
Copy Markdown
Collaborator

🚀 Available in v1.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:demo-app Changes specific to demo app released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants