Fix broken and uncompilable GetStream with starscream 4.0.x #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
This pull request addresses an issue, where it has become non-functional due to recent changes in the Starscream library. Specifically, the Starscream library's 4.0.x (4.0.5 & 4.0.6) version update introduced a new enum case called
case peerClosed
inWebSocketEvent
enum class (details here) and has broken the conformance of the Client object to theWebSocketDelegate
protocol, leaving the project uncompilable.Build Error Encountered:
A screenshot of the encountered error is shown below:
The issue originates from the fact that GetStream has been set up to track the latest changes to the major version of Starscream through its Package.swift file:
Package.swift
The proposed solution in this pull request involves incorporating the new
WebSocketEvent.peerClosed
enum case and updating the delegate method inputs to receive an abstraction of WebSocket, consistent with the WebSocketClient definition.The resolved state without errors is depicted in the screenshot below:
CLA