Implement hiding shadowed messages in the IStreamChannel messages and… #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why tests didn't trigger 🤔 but all are passing locally: |
|
The workflow got automatically paused by GH |
slavabobik
approved these changes
Apr 29, 2025
| { | ||
| var streamMessage = Cache.TryCreateOrUpdate(dto, out var wasCreated); | ||
| streamMessage = Cache.TryCreateOrUpdate(dto, out var wasCreated); | ||
| if (wasCreated) |
There was a problem hiding this comment.
is possible to reduce nesting level? Like:
if !wasCreated {
return ....
}
// do other logic
There was a problem hiding this comment.
Since this PR is urgent and this is a formatting change I'll fix it in a separate PR
sierpinskid
deleted the
feature/uni-91-filter-out-shadowed-messages-in-the-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pinned messages