Fix accessibility button shapes shown in navigation link views #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
|
martinmitrevski
approved these changes
Apr 9, 2025
martinmitrevski
deleted the
fix/accessibility-button-shape-shown-in-navigation-links
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
#721
https://linear.app/stream/issue/IOS-658/unexpected-rounded-rectangle-under-message-composer-on-channel-screen
🎯 Goal
Fix accessibility button shapes shown in the composer as well as in the channel list.
🛠 Implementation
An opacity of 0 is set to the navigation link label (EmptyView) to make sure the button shape is not shown.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo