Skip to content

Show all members in direct message channel info view #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves https://linear.app/stream/issue/IOS-679/display-all-dm-members-in-channel-info-view.

🎯 Goal

Until now, we did distinction only per channel type, not per number of members. This makes situations like DMs not displaying all members.

We should instead take into consideration the member count, which this PR addresses.

🛠 Implementation

Updated the logic in the channel info view.

🧪 Testing

Open few DMs with multiple members, make sure all the members are shown in the info view on the top right.

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner February 18, 2025 13:06
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Feb 18, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.59 MB 7.6 MB +1 KB 🟢

Copy link

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested with various distinct channels with various member counts and group channels - works as expected now!

@martinmitrevski martinmitrevski merged commit 96aeb8f into develop Feb 18, 2025
12 checks passed
@martinmitrevski martinmitrevski deleted the channel-info-dm-members branch February 18, 2025 13:58
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants