Skip to content

Only show "Pin/Unpin message" Action if user has permission #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

sheep-q
Copy link
Contributor

@sheep-q sheep-q commented Feb 10, 2025

🔗 Issue Link

N/A

🎯 Goal

When long tap on a message to show actions view, user shouldn't see Pin/Unpin message action if they don't have permission.

🛠 Implementation

Check capability before adding Pin/Unpin Message action

🧪 Testing

Change user permissions and verify that the action can or cannot be seen

🎨 Changes

Screenshot 2025-02-11 at 08 43 18

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@sheep-q sheep-q requested a review from a team as a code owner February 10, 2025 07:35
@sheep-q sheep-q force-pushed the fix/pin_unpin_message_action branch 2 times, most recently from 27c0ebf to 9b997a0 Compare February 10, 2025 08:08
@sheep-q sheep-q force-pushed the fix/pin_unpin_message_action branch from 9b997a0 to f046ff7 Compare February 11, 2025 02:55
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheep-q Thank you for your contribution. I have verified the change and will merge it shortly.

@laevandus laevandus merged commit 5a7e399 into GetStream:develop Feb 11, 2025
5 of 9 checks passed
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Feb 28, 2025
@laevandus
Copy link
Contributor

Hi @sheep-q , 4.73.0 was released today

@sheep-q
Copy link
Contributor Author

sheep-q commented Feb 28, 2025

Thank you @laevandus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants