Skip to content

Change timestamp formatting according to the default design #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 18, 2023
Merged

Change timestamp formatting according to the default design #2736

merged 5 commits into from
Aug 18, 2023

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Aug 16, 2023 •
edited
Loading

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/496

🎯 Goal

Change the Channel List message timestamp formatting according to the default design and the other SDKs.

📝 Summary

  • A new formatter is introduced, the Appearance.formatters.channelListMessageTimestamp
  • The ChatChannelListItemView now uses this new formatter.

🎨 Showcase

🧪 Manual Testing Notes

ACs:

  • Messages from today show the time.
  • Messages from yesterday show Yesterday.
  • Messages from last week show the week day (eg. Thursday).
  • Messages from before that, show the date with the mm/dd/yy format.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Aug 16, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner August 16, 2023 17:59
@nuno-vieira nuno-vieira force-pushed the fix/channel-list-timestamp-logic-according-to-default-design branch from 89aa39f to 0c673f5 Compare August 16, 2023 18:32
@nuno-vieira nuno-vieira added the 🤞 Ready For QA A PR that is Ready for QA label Aug 17, 2023
@nuno-vieira nuno-vieira requested a review from polqf August 17, 2023 16:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.8% 83.8% Coverage
0.0% 0.0% Duplication

testableapple
testableapple approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@testableapple testableapple added 🟢 QAed A PR that was QAed and removed 🤞 Ready For QA A PR that is Ready for QA labels Aug 18, 2023
@nuno-vieira nuno-vieira merged commit 2717345 into develop Aug 18, 2023
@nuno-vieira nuno-vieira deleted the fix/channel-list-timestamp-logic-according-to-default-design branch August 18, 2023 10:13
@nuno-vieira nuno-vieira mentioned this pull request Aug 28, 2023
Merged
@laevandus laevandus mentioned this pull request May 21, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polqf polqf polqf approved these changes

@testableapple testableapple testableapple approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🟢 QAed A PR that was QAed 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @polqf @testableapple