Merged
Conversation
Contributor
SDK Size
|
isekovanic
reviewed
Feb 27, 2026
package/src/components/Message/MessageSimple/Headers/MessageReminderHeader.tsx
Outdated
Show resolved
Hide resolved
isekovanic
reviewed
Feb 27, 2026
package/src/components/Message/MessageSimple/Headers/SentToChannelHeader.tsx
Outdated
Show resolved
Hide resolved
isekovanic
reviewed
Feb 27, 2026
package/src/components/Message/MessageSimple/Headers/SentToChannelHeader.tsx
Outdated
Show resolved
Hide resolved
isekovanic
reviewed
Feb 27, 2026
isekovanic
reviewed
Feb 27, 2026
isekovanic
approved these changes
Feb 27, 2026
Contributor
isekovanic
left a comment
There was a problem hiding this comment.
Please address the couple of comments I've left, looks good otherwise
isekovanic
reviewed
Feb 27, 2026
package/src/components/Message/MessageSimple/Headers/SentToChannelHeader.tsx
Outdated
Show resolved
Hide resolved
isekovanic
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several significant updates to the handling and display of message reminders and thread navigation in the sample app and core library. The main changes include refactoring the way message reminder headers are implemented, improving thread navigation (including scrolling to a targeted message), and exposing new header components for easier customization. Additionally, some code cleanup and minor UI improvements are included.
Message Reminder and Header Refactoring:
Removed the custom
MessageReminderHeaderand related logic from the sample app, shifting responsibility for reminder headers to the core library and exposing them as customizable components (MessageReminderHeader,MessageSavedForLaterHeader,SentToChannelHeader). [1] [2] [3] [4] [5] [6] [7]Updated the message actions to use the
Bellicon directly from the core library instead of a local copy, and adjusted the icon prop to usestrokeinstead ofpathFillfor consistency. [1] [2] [3]Thread Navigation and Targeted Message Scroll:
Enhanced thread navigation by passing an optional
targetedMessageIdwhen navigating to the thread screen, allowing the UI to scroll directly to a specific message within a thread. [1] [2] [3] [4] [5]Added an
onBackPressThreadcallback to the thread context and channel props, enabling the thread screen to return to the channel screen and optionally scroll to a targeted message. [1] [2] [3] [4] [5] [6]Component and Prop Management:
MessageHeaderandMessageReminderHeaderprops in the sample app screens, relying on the core library's exposed components and context for message header rendering. [1] [2] [3] [4]Minor Improvements and Cleanup:
Fixed a minor translation string in
ChannelPreviewMessageto remove an unnecessary colon from the translation key.Ensured the
onThreadSelectprop is passed to theMessageWithContextcomponent for better thread handling.These changes collectively improve the flexibility, maintainability, and user experience of message reminders and thread navigation in the app.