feat: show delivery status and read status on the message and channel preview #3258
Conversation
SDK Size
|
| import 'react-native-gesture-handler'; | ||
| import { AppRegistry } from 'react-native'; | ||
| import { enableScreens } from 'react-native-screens'; | ||
| import './src/utils/bootstrapBackgroundMessageHandler'; |
There was a problem hiding this comment.
Move this before RNGH and all of the other imports please, it's important that the very first thing encountered whenever App.tsx is hit is the bootstrapping
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> |
There was a problem hiding this comment.
Please revert these changes when you can, they do not seem correct
| const areEqual = (prevProps: MessagePropsWithContext, nextProps: MessagePropsWithContext) => { | ||
| const { | ||
| chatContext: { mutedUsers: prevMutedUsers }, | ||
| deliveredBy: prevDeliveredBy, |
There was a problem hiding this comment.
Shouldn't this be deliveredTo or deliveredToCount or something similar ?
|
|
||
| export const MessageStatus = (props: MessageStatusProps) => { | ||
| const { message, readBy, threadList } = useMessageContext(); | ||
| const { channel } = useChannelContext(); |
There was a problem hiding this comment.
Since we're only really using the channel to see if the members length is greater than 2, perhaps we could precalculate this elsewhere and just pass it to be used as an atomic value ? That way we won't have to worry about unstable references changing (nor probably need to run useChannelContext() like this downstream (which will trigger many changes). Having it here pre-memoization is definitely an improvement but we can still move it outside since we were anyway never passing it as a prop so it isn't breaking either.
There was a problem hiding this comment.
Apart from the couple of comments I don't have any other concrete objections ! We have to refactor the ChannelPreview at some point, it feels like it's slowly getting out of hand and it could use some love.
Please profile the PR on both platforms to make sure we aren't degrading performance further (it doesn't look like it at first glance, but let's be sure of it)
3 participants
No description provided.