Repository navigation
fix: set thread cursor when initied from setItems - #1898
Merged
Merged
Conversation
szuperaz
requested review from
MartinCupela,
isekovanic,
oliverlaz,
santhoshvai and
vishalnarkhede
as code owners
October 2, 2026 20:08
isekovanic
approved these changes
Oct 3, 2026
Contributor
|
this looks good and I'll merge it and on Monday I'll remove the extremely bad disfunction during same length queried on RN (despite surfacing this bug it's very risky for pruning as well) |
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 5, 2026
## [10.0.0-rc.18](v10.0.0-rc.17...v10.0.0-rc.18) (2026-10-05) ### ⚠ BREAKING CHANGES * adopt TS generator changes (#1896) ### Bug Fixes * set thread cursor when initied from setItems ([#1898](#1898)) ([63bef43](63bef43)) ### Features * adopt TS generator changes ([#1896](#1896)) ([82af6de](82af6de))
|
🎉 This PR is included in version 10.0.0-rc.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/stream/issue/REACT-1206/rn-cant-load-older-replies-on-long-threads
Description of the changes, What, Why and How?
Flagged and fixed by Claude while working on something else for RN: in RN if a thread has more than 50 replies, we can't load older ones, only the inital 50 that's loaded when opening the thread.
The bug is not in RN, it is just more noticeable there. The bug is in stream-chat-js: when a thread is initiated via calling
setItemscursor was not set. This meant that when we wanted to load older replies, we loaded the latest replies (that were already loaded). At this point, the cursor is set properly. At this point, the two SDKs diverge:Changelog