-
Notifications
You must be signed in to change notification settings - Fork 308
Move offline support to LLC #6062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VelikovPetar
wants to merge
5
commits into
v7
Choose a base branch
from
feature/AND-774_move_offline_support_to_client
base: v7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+896
−2,550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
DB Entities have been updated. Do we need to upgrade DB Version? |
Contributor
SDK Size Comparison 📏
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




🎯 Goal
Removes the
stream-chat-android-offlinemodule and moves theStreamOfflinePluginFactory/OfflinePluginto the LLC(stream-chat-android-client).Important: This is just the first part of the offline support refactor. The next step is to move the
statesupport down to the client. Afterwards, we need to revisit the points documented in the following ticket. This is extremely important before publishingV7.🛠 Implementation details
clientmodule, in package:io.getstream.chat.android.internal.offlineStreamOfflinePluginFactoryis nowinternalinstead of public to disallow instantiationOfflineConfigclass, via theChatClient.Builder.offlineConfig(OfflineConfig)methodChatClientrelated to the plugin setup - but in the end, theOfflinePluginis still setup internally based on theOfflineConfig.🎨 UI Changes
NA
🧪 Testing
The offline support is now enabled by default.
You can test that everything works as expected without any changes in the samples.
ChatClient.Builder().offlineSupport(OfflineConfig(enabled = false))- and verify that no data is available offline.