-
Notifications
You must be signed in to change notification settings - Fork 309
Allow opening threads whose root is a deleted message #6046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opening threads whose root is a deleted message #6046
Conversation
SDK Size Comparison 📏
|
WalkthroughThis pull request enables opening threads when the root message has been deleted. The fix updates message deletion handling across the Android UI framework by wiring click listeners to deleted messages, enhancing the deleted message layout with a thread footnote reference, and enabling previously blocked tests that verify this functionality. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…or_deleted_messages' into bug/fix_unable_to_open_threads_for_deleted_messages
|



🎯 Goal
Fixes 2 bugs:
X Thread Repliesfooter for deleted messages, and allow opening those threadsResolves: https://linear.app/stream/issue/AND-273/chatcompose-the-thread-is-locked-after-deleting-a-parent-message
🛠 Implementation details
clickModifierinMessageItemto always handle clicks if the message belongs to a threadthread_guidelineto thedeleted_message_item. Render the thread footer, and bind it to the click listeners🎨 UI Changes
compose_before.mp4
compose_after.mp4
xml_before.mp4
xml_after.mp4
🧪 Testing
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.