Skip to content

Deprecate invalid getReactions method #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 6 commits into from
Dec 11, 2025
+6 −12
Merged

Deprecate invalid getReactions method #6039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7939bf1
Deprecate invalid getReactions method.
VelikovPetar Dec 10, 2025
fb3711c
Update CHANGELOG.md.
VelikovPetar Dec 10, 2025
0f945be
Update DEPRECATIONS.md.
VelikovPetar Dec 10, 2025
d6c0bea
Remove tests.
VelikovPetar Dec 10, 2025
6c88e15
Change deprecation level from error to warning.
VelikovPetar Dec 10, 2025
4b4b6a8
Merge branch 'develop' into bug/deprecate_wrong_method
VelikovPetar Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
### ⚠️ Changed
- Deprecate `ChatClient.markThreadUnread(String, String, String, String)` because marking a thread as unread from a given message is currently not supported. [#6027](https://github.com/GetStream/stream-chat-android/pull/6027)
- Deprecate `ChannelClient.markThreadUnread(String, String)` because marking a thread as unread from a given message is currently not supported. [#6027](https://github.com/GetStream/stream-chat-android/pull/6027)
- Deprecate `ChannelClient.getReactions(messageId: String, firstReactionId: String, limit: Int)` because it is no longer supported. [#6039](https://github.com/GetStream/stream-chat-android/pull/6039)

### ❌ Removed

Expand Down
1 change: 1 addition & 0 deletions DEPRECATIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ This document lists deprecated constructs in the SDK, with their expected time

| API / Feature | Deprecated (warning) | Deprecated (error) | Removed | Notes |
|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------|-----------------------|-----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `ChannelClient.getReactions(messageId: String, firstReactionId: String, limit: Int)` method | 2025.12.10 ⌛ | | | This method has been deprecated because it is no longer supported. Use `ChannelClient.getReactions(messageId: String, offset: Int, limit: Int)` instead. |
| `AttachmentsPickerViewModel.loadData()` method | 2025.12.10 ⌛ | | | This method is deprecated because it is no longer used and will be removed in future versions. |
| `ChatClient.markThreadUnread(channelType: String, channelId: String, threadId: String, mesageId: String)` method | 2025.11.24 ⌛ | | | This method is deprecated because marking a thread as unread from a given message is currently not supported, and the passed `messageId` is ignored. Use `ChatClient.markThreadUnread(channelType: String, channelId: String, threadId: String)` instead. |
| `ChannelClient.markThreadUnread(threadId: String, mesageId: String)` method | 2025.11.24 ⌛ | | | This method is deprecated because marking a thread as unread from a given message is currently not supported, and the passed `messageId` is ignored. Use `ChannelClient.markThreadUnread(threadId: String)` instead. |
Expand Down
4 changes: 4 additions & 0 deletions ...at-android-client/src/main/java/io/getstream/chat/android/client/channel/ChannelClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,12 @@
return client.getReactions(messageId, offset, limit)
}

@Deprecated(
message = "This operation is not supported. " +
"Use ChannelClient.getReactions(messageId: String, offset: Int, limit: Int) instead.",
)
@CheckResult
public fun getReactions(

Check warning on line 681 in stream-chat-android-client/src/main/java/io/getstream/chat/android/client/channel/ChannelClient.kt

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 


See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-android&issues=AZsIfPxQPHwOkyr-gSPo&open=AZsIfPxQPHwOkyr-gSPo&pullRequest=6039
messageId: String,
firstReactionId: String,
limit: Int,
Expand Down
5 changes: 0 additions & 5 deletions stream-chat-android-docs/src/main/java/io/getstream/chat/docs/java/client/cms/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,6 @@ public void paginatingReactions() {
offset = 10;
channelClient.getReactions("message-id", offset, limit)
.enqueue(result -> { /* ... */ });

// Get 10 reactions after particular reaction
String reactionId = "reaction-id";
channelClient.getReactions("message-id", reactionId, limit)
.enqueue(result -> { /* ... */ });
}

/**
Expand Down
7 changes: 0 additions & 7 deletions ...am-chat-android-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/client/cms/Messages.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,13 +295,6 @@ class Messages(
offset = 10,
limit = 10,
).enqueue { /* ... */ }

// Get 10 reactions after particular reaction
channelClient.getReactions(
messageId = "message-id",
firstReactionId = "reaction-id",
limit = 10,
).enqueue { /* ... */ }
}

/**
Expand Down
Loading