Skip to content

Conversation

@VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Nov 26, 2025

🎯 Goal

We shouldn't show the Thread Reply message option for messages which are thread replies. This is especially problematic for replies which are also sent in the channel - In that case attempting to send a thread reply would result in an unrecoverable error, because nested replies are not allowed.

🛠 Implementation details

  • Add additional !message.isThreadReply() to the canThreadReplyToMessage helper method

🎨 UI Changes

Before After
before.mp4
after.mp4

🧪 Testing

  1. Create a thread
  2. Send a message and check Send to channel
  3. Exit the thread
  4. Long press on the Send to channel -> the Thread Reply option should not be visible

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.25 MB 0.00 MB 🟢
stream-chat-android-offline 5.47 MB 5.47 MB 0.00 MB 🟢
stream-chat-android-ui-components 10.58 MB 10.58 MB 0.00 MB 🟢
stream-chat-android-compose 12.81 MB 12.81 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review November 26, 2025 10:13
@VelikovPetar VelikovPetar requested a review from a team as a code owner November 26, 2025 10:13
@sonarqubecloud
Copy link

@VelikovPetar VelikovPetar merged commit 1f29df6 into develop Nov 26, 2025
13 checks passed
@VelikovPetar VelikovPetar deleted the bug/AND-925_fix_thread_reply_option_shown_for_thread_roots_and_replies branch November 26, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants