-
Notifications
You must be signed in to change notification settings - Fork 309
Improve SwipeToReply component in scroller containers #5946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SwipeToReply component in scroller containers #5946
Conversation
2281e0a to
bafe9ff
Compare
SDK Size Comparison 📏
|
…g gesture events if the horizontal scrolling dominates the vertical scrolling
6dd4268 to
b0b0a05
Compare
VelikovPetar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just for my understanding, is it not possible to disable the SwipeToReply action if there is a vertical scroll active? (I am not suggesting it as a better solution, just as an idea).
Sorry, can you elaborate |
I was thinking something like: val lazyListState = rememberLazyListState()
val swipeEnabled = !lazyListState.isScrollInProgressBut on a closer inspection, we cannot really easily access the the list state here unfortunately. |
Yes. |
|


🎯 Goal
Improve
SwipeToReplycomponent in scroller containers by only handling gesture events if the horizontal scrolling dominates the vertical scrolling🎨 UI Changes
Screen_recording_20251003_142616.webm
Screen_recording_20251003_141621.webm
🧪 Testing