Skip to content

Conversation

@VelikovPetar
Copy link
Contributor

🎯 Goal

Change AttachmentPickerAction from sealed interface to interface to allow custom implementations.
Resolves: https://linear.app/stream/issue/AND-758/expose-attachmentpickeraction-interface-for-custom-actions

🛠 Implementation details

Change AttachmentPickerAction from sealed interface to interface

🎨 UI Changes

NA

🧪 Testing

Create a class which implements the AttachmentPickerAction to verify that it is now extensible outside its own module.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.23 MB 3.23 MB 0.00 MB 🟢
stream-chat-android-offline 3.45 MB 3.45 MB 0.00 MB 🟢
stream-chat-android-ui-components 10.54 MB 10.54 MB 0.00 MB 🟢
stream-chat-android-compose 12.75 MB 12.75 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar requested a review from Copilot October 1, 2025 12:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes AttachmentPickerAction from a sealed interface to a regular interface to enable custom implementations outside the SDK module. This allows developers to extend the attachment picker functionality with their own custom actions.

Key Changes

  • Removed the sealed modifier from the AttachmentPickerAction interface
  • Updated the changelog to document this breaking change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
AttachmentPickerAction.kt Removed sealed modifier to allow external implementations
CHANGELOG.md Added changelog entry documenting the interface change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@VelikovPetar VelikovPetar marked this pull request as ready for review October 1, 2025 12:06
@VelikovPetar VelikovPetar requested a review from a team as a code owner October 1, 2025 12:06
@VelikovPetar VelikovPetar requested a review from Copilot October 1, 2025 12:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andremion andremion enabled auto-merge (squash) October 6, 2025 09:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@andremion andremion merged commit a6f4bfc into develop Oct 6, 2025
13 checks passed
@andremion andremion deleted the feature/expose-attachment-picker-action branch October 6, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants