-
Notifications
You must be signed in to change notification settings - Fork 308
Change AttachmentPickerAction from sealed interface to interface
#5943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Size Comparison 📏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes AttachmentPickerAction from a sealed interface to a regular interface to enable custom implementations outside the SDK module. This allows developers to extend the attachment picker functionality with their own custom actions.
Key Changes
- Removed the
sealedmodifier from theAttachmentPickerActioninterface - Updated the changelog to document this breaking change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AttachmentPickerAction.kt | Removed sealed modifier to allow external implementations |
| CHANGELOG.md | Added changelog entry documenting the interface change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|



🎯 Goal
Change
AttachmentPickerActionfrom sealed interface to interface to allow custom implementations.Resolves: https://linear.app/stream/issue/AND-758/expose-attachmentpickeraction-interface-for-custom-actions
🛠 Implementation details
Change
AttachmentPickerActionfromsealed interfacetointerface🎨 UI Changes
NA
🧪 Testing
Create a class which implements the
AttachmentPickerActionto verify that it is now extensible outside its own module.