Prevent focusing message if the listState flow was cancelled before a message item was loaded.

[VelikovPetar]

🎯 Goal

Resolves: https://linear.app/stream/issue/AND-634/upgrade-to-latest-stream-sdk-causing-illegalstateexception-crash-in

Prevents calling focusMessage in the init block of the MessageListController if the listState flow was cancelled before a message was loaded. The following setup in the initialFocusMessage() method:

private fun initialFocusMessage() {
   messageId ?: return // No initial focus if no message id is provided
   scope.launch {
       listState
         .onCompletion {
            // ...
         }
         .first { it.messageItems.isNotEmpty() }
   }
}

behaves in the following way: The onCompletion block will be invoked in two scenarios:

• When the flow is completed (by .first { it.messageItems.isNotEmpty() })
• When the flow is cancelled (by cancelling the scope)

We should prevent calling the focusChannelMessage from the onCompletion block in the case when the flow cancelled, because the UI might not be present anymore OR no messages are loaded yet OR the user could already be disconnected.

Note: The crash stack trace is: ChatClient::connectUser() must be called before resolving any dependency - but the crash is triggered much earlier in the flow in the focusMessage method, where we attempt to focus a message when we cancel the MessageList scope.

(See attached videos and testing for reproduction steps)

🛠 Implementation details

• Prevent calling focusChannelMessage from the onCompleted block in the MessageListController.initialFocusMessage() message.

🎨 UI Changes

Before	After
focus-message-crash-before.mp4	focus-message-crash-after.mp4

🧪 Testing

Currently only reproduce-able after a process death

1. Set background limit process to "No background processes"
2. Apply the provided patch
3. Open compose app
4. Open a channel (note that the channel auto focuses the last message - change from patch)
5. Put app in background
6. Open a different app
7. Return to compose sample
8. The app should be restored on the MessageList in loading state (because we don't have reconnect logic after process death)
9. Tap back (this cancels the scope)
10. The app should not crash

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-chat-android-client	3.16 MB	3.16 MB	0.00 MB	🟢
stream-chat-android-offline	3.38 MB	3.38 MB	0.00 MB	🟢
stream-chat-android-ui-components	10.43 MB	10.43 MB	0.00 MB	🟢
stream-chat-android-compose	12.53 MB	12.53 MB	-0.00 MB	🚀

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud